Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve import performance #953

Merged
merged 14 commits into from
Jul 17, 2024
Merged

Conversation

hahn-kev
Copy link
Collaborator

right now crdt import creates one commit pr entry, this is a big bottleneck, this change attempts to improve that by making a bulk import method to work around this.

Copy link

github-actions bot commented Jul 12, 2024

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4c7d15d. ± Comparison against base commit 179fdec.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2024

FW Lite Unit Tests

35 tests  +1   35 ✅ +1   4s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4c7d15d. ± Comparison against base commit 179fdec.

♻️ This comment has been updated with latest results.

@hahn-kev hahn-kev force-pushed the chore/improve-crdt-import-performance branch from 4c77c30 to b74a6ca Compare July 12, 2024 03:49
Copy link

github-actions bot commented Jul 12, 2024

C# Unit Tests

52 tests   52 ✅  5s ⏱️
10 suites   0 💤
 1 files     0 ❌

Results for commit 4c7d15d.

♻️ This comment has been updated with latest results.

backend/FwLite/LcmCrdt/ProjectsService.cs Dismissed Show dismissed Hide dismissed
@hahn-kev hahn-kev marked this pull request as ready for review July 15, 2024 04:47
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general; just a couple places I have comments on, that shouldn't block merging.

@hahn-kev hahn-kev merged commit 6737890 into develop Jul 17, 2024
15 of 16 checks passed
@hahn-kev hahn-kev deleted the chore/improve-crdt-import-performance branch July 17, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants